Ticket #1053 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Parent to response annotations need to be updated when changing annotation type.

Reported by: amit Assigned to: ssterling
Priority: critical Milestone:
Component: ambra Version: 0.9.1-SNAPSHOT
Keywords: annotation type Cc:
Blocking: Blocked By:

Description

Ambra converts a 'Comment' annotation to 'Formal Correction', 'Minor Correction', etc. under certain circumstances. Unfortunately when it creates the new annotation it is not updating the 'root' for responses to the new annotation. Please see the thread on the ambra-dev mailing list Changing Annotation Types.

Dependency Graph

Change History

11/12/08 14:53:53 changed by amit

  • summary changed from Parent to response annotations need to be updated when chaning annotation type. to Parent to response annotations need to be updated when changing annotation type..

Spelling correction.

11/19/08 15:58:46 changed by ssterling

  • status changed from new to closed.
  • resolution set to fixed.

Replies (also known as "responses" or "comments") associated to an Annotation are now preserved when that Annotation's "type" (Minor Correction, Retraction, Formal Correction, or Note) is changed.

Also, there was a bug in adminTop.ftl which was deleting the Annotation when the Annotation type was changed to "Note". This bug (hidden by the previous Annotation-type-changing functionality) manifested to the administrative user merely as the "flag" not being automatically deleted when an Annotation had its type changed to "Note". It was an annoyance, but nothing more, which is probably why it was left in place. This issue has also been corrected.

11/19/08 16:08:16 changed by amit

  • status changed from closed to reopened.
  • resolution deleted.

Huh? Where is the code?

11/20/08 14:53:43 changed by ssterling

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6726]) Fixes #1053

Replies (also known as "responses") associated to an Annotation are now preserved when that Annotation's "type" (Minor Correction, Retraction, Formal Correction, or Note) is changed. Previously, a new Annotation (with a new DOI) was created and the "replies" from the old Annotation were modified to refer to the new Annotation. Now, the new Annotation uses the same DOI as the old Annotation and the "replies", permissions, etc (from the old annotation) are not changed.

Also, there was a bug in adminTop.ftl which was deleting the Annotation when the Annotation type was changed to "Note". This bug (hidden by the previous Annotation-type-changing functionality) manifested to the administrative user merely as the "flag" not being automatically deleted when an Annotation had its type changed to "Note". It was an annoyance, but nothing more, which is probably why the bug was left in place. This issue has also been corrected.

fixes #1053

02/25/09 14:46:46 changed by

  • milestone deleted.

Milestone 0.9.1 deleted